Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix treatment of missing ESMF library #264

Merged
merged 2 commits into from
Sep 25, 2021
Merged

Fix treatment of missing ESMF library #264

merged 2 commits into from
Sep 25, 2021

Conversation

davidhassell
Copy link
Collaborator

Fixes: #263

sadielbartholomew
sadielbartholomew requested changes Sep 24, 2021
View reviewed changes
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, fixing the issue at hand, except that the new error message introduced needs negating (see inline comment) else much confusion may ensue! Once that's addressed, feel free to merge (else I can do it when I check back).

cf/regrid/utils.py Outdated Show resolved Hide resolved
@davidhassell @sadielbartholomew
Add missing 'not' to error message
a6b93a8 
Co-authored-by: Sadie L. Bartholomew <[email protected]>
@davidhassell davidhassell merged commit 76467e6 into NCAS-CMS:master Sep 25, 2021
@davidhassell davidhassell added this to the 3.11.0 milestone Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadielbartholomew sadielbartholomew sadielbartholomew requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

Import fails with NameError: name 'ESMF' is not defined
2 participants
@davidhassell @sadielbartholomew