Extend indexed assignment and binary operations to bounds, if present.

[davidhassell]

Fixes #146

[sadielbartholomew]

I've just done a trivial merge conflict resolution to resolve one line conflicting with the PR #149 which I just merged, so that this can be merged once reviewed shortly, assuming all is good.

[davidhassell]

Thanks @sadielbartholomew. The changes discussed in #146 still need to, be added, though. I'll be looking at that again today.

[sadielbartholomew]

Oops, sorry @davidhassell I thought it was ready for review. Ping me when it is ready. Thanks.

[davidhassell]

Note that the names combine_bounds_with_coordinates, OperandBoundsCombination, and 'COMBINE_BOUNDS_WITH_COORDINATES' are placeholders until we decide on what we really want to to call them.

[sadielbartholomew]

Is this ready for review now @davidhassell (excluding the name which we are yet to choose, that is)?

[davidhassell]

Hi @sadielbartholomew - please do review, thanks.

[davidhassell]

(I realise that _binary_operation might need some interior_ring treatment, still ...)

[sadielbartholomew]

(I realise that _binary_operation might need some interior_ring treatment, still ...)

@davidhassell I didn't start a review, and am doing some ES-DOC work until the end of my working day, so go ahead if you want to still make changes. Otherwise I'll start the review tomorrow bearing this in mind, & ignoring the name. Thanks.

[sadielbartholomew]

I'm mid-review on checking through the intricacies of the various configurations, but everything seems sound generally so far. I'm leaving some minor comments while I finish up.

[sadielbartholomew]

Thanks for addressing those small items of feedback, I'll be an hour or so finishing up checking the functionality is watertight then can approve, but everything thus far is working as decided and documented.

[sadielbartholomew]

Functionality tested completed off the state of the branch including the final name change and everything works as (well) documented. Great stuff.

One final thought I had is that it might be good to note the new method in the changelog, as well as the note about the change in behaviour. This can easily be done post-merge though.

[davidhassell]

Good idea. Changelog done. Merging. Hooray!