-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test update to GitHub Actions (run against cfdm master) #118
Test update to GitHub Actions (run against cfdm master) #118
Conversation
Okay, first try has failed because it seems the relative directory structure of the job host VM isn't as I thought it was. The next commit I push in a moment tweaks the specified directories to change into before running |
Opening & closing to re-trigger. |
18ecdd2
to
5d99069
Compare
5d99069
to
42fe43b
Compare
This seems to be required now that actions/checkout@v2 for the cf-python repo itself is done with a path of 'main' set.
(Squashing & force-pushing to keep the commit history tidy & prevent having several correction commits.) The run on cfdm master is working for all jobs except Python 3.5 ones where we are hitting a separate issue whereby netCDF4 isn't being installed successfully, I suspect this is due to it or one of its dependencies having dropped support for 3.5 since there is a deprecated warning given so 3.5 may soon be unsupported. Investigating, to confirm or otherwise, now. |
Yes, I will remove 3.5 from the run matrix for now, but @davidhassell we should discuss whether we should drop support for deprecated 3.5 ourselves (FYI it reaches "end of life" this month). |
I think this should be the last time I need to re-trigger, since the Python 3.X jobs for X != 5 all reached the 'run test suite' step for the previous try, so should pass without 3.5 jobs failing to cancel them like before. Let's see... |
Hmm, one spurious test failure that I can't recreate locally:
Trying once more in case it is a non-deterministic test. |
Okay the same test as above has failed again on the Python 3.8 job, so I will investigate that separately. The run against cfdm master aspect is finalised, since the jobs run to completion even if they fail, so this is now good to merge. |
No description provided.