Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reset LSM accumulations if RSTRT_SWC flag is set to 'no reset' #752

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rcabell
Copy link
Collaborator

@rcabell rcabell commented May 21, 2024

TYPE: bug fix

KEYWORDS: NoahMP, accumulations, restarts

SOURCE: NCAR Internal

DESCRIPTION OF CHANGES: Previously, if the RSTRT_SWC flag was set to 0 in the hydro.namelist file, only Hydro accumulations were preserved, but LSM accumulations were still reset.

TESTS CONDUCTED:

Ran with and without fix, using Croton test case, with daily restarts. When comparing LDASOUT and RESTART files, accumulation field increase correctly for the following variables:

UGDRNOFF, ACCET, SFCRUNOFF, UDRUNOFF, ACCPRCP, ACCECAN, ACCEDIR, ACCETRAN

as expected, during the initial 24 hours, no differences occur.

Copy link
Member

@scrasmussen scrasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and I always enjoy formatting changes!

Tests done: built, ran and then ran from a restart, looked at a few accumulated variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants