bugfix: optional and intent(inout) attributes for glacier arrays #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrasmussen
force-pushed
the
bugfix/optional-glacier-variables
branch
from
ab5f128
to
5036a87
Compare
scrasmussen
force-pushed
the
bugfix/optional-glacier-variables
branch
from
5036a87
to
bbc22d9
Compare
…out. Allocated array glact was becoming unallocated upon entry to the readland_hrldas subroutine cause it was intent(in). Changing variable attribute to optional fixes or changing intent to inout fixes this. Variable is allocated before and never in the function, so both are appropriate.
… added check for variables being allocated
scrasmussen
force-pushed
the
bugfix/optional-glacier-variables
branch
from
bbc22d9
to
2e8197a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: Crocus, Glacier, Variable Attribute
SOURCE: Soren Rasmussen, NCAR
DESCRIPTION OF CHANGES: Changing Crocus glacier arrays from
allocatabletooptional. Allocated arrayglactwas becoming unallocated upon entry to thereadland_hrldassubroutine. Changing variable attribute tooptionalfixes this. Variable will never be allocated in the function so this is appropriate. Changing intent toinoutalso fixes this.TESTS CONDUCTED: Builds and runs Huijie Glacier domain.
NOTES:
Checklist
NEWS.md