Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text only: MPI Case Style #723

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

scrasmussen
Copy link
Member

@scrasmussen scrasmussen commented Oct 18, 2023

TYPE: text only, no impact

KEYWORDS: formatting, MPI

SOURCE: Soren Rasmussen, NCAR

DESCRIPTION OF CHANGES: Formatting MPI function calls to standard MPI style of MPI_Foo_bar(). This is only changing the capitalization of letters so it is a text only change and shouldn't touch anything else.

TESTS CONDUCTED: Built and ran Croton just to double check the text-only change didn't accidentally affect something else.

NOTE: tried switching from mpi to mpi_f08 but because some of libraries and the models we couple with use the older style, meaning all the MPI types are integers, it currently won't work out.

Checklist

  • Closes issue #xxxx (An issue must exist or be created to be closed. The issue describes and documents the problem and general solution, the PR describes the technical details of the solution.)
  • Tests added (unit tests and/or regression/integration tests)
  • Backwards compatible
  • Requires new files? If so, how to generate them.
  • Documentation included
  • Short description in the Development section of NEWS.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants