Add scrape of outer edge of domain so water doesn't pile up. #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed in parallel and lots of prints. Fixed init issue with boundary adjustment variables and condensed. Changed looping to just cover boundaries. Fixed broadcast call. Passes ncores for small test domain. Print mods. Remove prints.
|
Should |
aubreyd
force-pushed
the
overland_edge_fix_new_structure
branch
from
7f0a229
to
7c04234
Compare
|
We are keeping real*4 since these are not incremental additions, just batch at end. Removed confusing comment. |
rcabell
pushed a commit
that referenced
this pull request
Nov 1, 2022
Add scrape of outer edge of domain so water doesn't pile up
scrasmussen
pushed a commit
to scrasmussen/wrf_hydro_nwm_public
that referenced
this pull request
Aug 4, 2023
Add scrape of outer edge of domain so water doesn't pile up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TYPE: bug fix
KEYWORDS: overland flow
SOURCE: Aubrey D., NCAR
DESCRIPTION OF CHANGES:
In the 1D overland flow scheme, the outer edge cells are not properly treated (they are in 2D scheme). This can cause water to pile up on the edges, particularly with limited infiltration (e.g., glacier cells). We do a brute force method here to scrape water above maximum retention depth from these outer cells and capture it in QBDRY. This should someday be updated to match the 2D approach.
ISSUE: The GitHub Issue that this PR addresses. For issue number 123, it would be:
TESTS CONDUCTED:
Tested fix over NWM-Alaska cutout domain and water no longer piles up on edge. Tested NWM-CONUS and confirmed minimal impacts (only along edges), passes ncores, passes perfect restart.
Checklist
Merging the PR depends on following checklist being completed. Add
Xbetween each of the squarebrackets if they are completed in the PR itself. If a bullet is not relevant to you, please comment
on why below the bullet.
NEWS.md