Lake Precision Update

[rcabell]

TYPE: enhancement

KEYWORDS: lake, numerics

SOURCE: dnyates

DESCRIPTION OF CHANGES: Increases floating-point precision used in lake calculations to doubles to allow tracking smaller changes

Checklist

Merging the PR depends on following checklist being completed. Add X between each of the square
brackets if they are completed in the PR itself. If a bullet is not relevant to you, please comment
on why below the bullet.

• [-] Closes issue #xxxx (An issue must exist or be created to be closed. The issue describes and documents the problem and general solution, the PR describes the technical details of the solution.)
• [-] Tests added (unit tests and/or regression/integration tests)
• Backwards compatible
• [-] Requires new files? If so, how to generate them.
• [-] Documentation included
• [-] Short description in the Development section of NEWS.md

[rcabell]

Regression tests show some small drifts in Gridded, AnA, and Long-Range tests (non-NWM Reach passed with no changes). @dnyates can you please look at these StdDev diffs and see if they're in the range you would expect? Gridded has a lot more differences than NWM configurations, and the cvol variable in particular has large differences.

Gridded:                           Long Range:                             AnA:

channel_rt                         restart_nudging                         restart_nudging

Variable       ...    StdDev       Variable            ...    StdDev       Variable            ...    StdDev
0  streamflow  ...  0.003717       0  model_discharge  ...  0.000002       0  model_discharge  ...  0.000002
1   q_lateral  ...  0.000000       1            nudge  ...  0.000000       1            nudge  ...  0.000000
2        Head  ...  0.000189

0  streamflow  ...  0.000798       0  model_discharge  ...  0.000002       0  model_discharge  ...  0.000007
1   q_lateral  ...  0.000000       1            nudge  ...  0.000000       1            nudge  ...  0.000000
2        Head  ...  0.000051

0  streamflow  ...  0.011093       0  model_discharge  ...  0.000011       0  model_discharge  ...  0.000018
1   q_lateral  ...  0.000000       1            nudge  ...  0.000000       1            nudge  ...  0.000000
2        Head  ...  0.000197

0  streamflow  ...  0.023870       0  model_discharge  ...  0.000206       0  model_discharge  ...  0.000635
1   q_lateral  ...  0.000000       1            nudge  ...  0.000000       1            nudge  ...  0.000000
2        Head  ...  0.000328

0  streamflow  ...  0.022383       0  model_discharge  ...  0.000199       0  model_discharge  ...  0.000726
1   q_lateral  ...  0.000000       1            nudge  ...  0.000000       1            nudge  ...  0.000000
2        Head  ...  0.000242

0  streamflow  ...  0.023891       0  model_discharge  ...  0.000191       0  model_discharge  ...  0.00071
1   q_lateral  ...  0.000000       1            nudge  ...  0.000000       1            nudge  ...  0.00000
2        Head  ...  0.000393

channel_rt_grid

Variable       ...    StdDev
0  streamflow  ...  0.003717
0  streamflow  ...  0.000798
0  streamflow  ...  0.011093
0  streamflow  ...   0.02387
0  streamflow  ...  0.022383
0  streamflow  ...  0.023891

restart_hydro

Variable    ...      StdDev
0    hlink  ...    0.000189
1   qlink1  ...    0.003717
2     cvol  ...    3.070980
3    resht  ...    0.000000
4   qlakeo  ...    0.000000

Variable    ...      StdDev
0    hlink  ...    0.000051
1   qlink1  ...    0.000798
2     cvol  ...    0.400578
3    resht  ...    0.000000
4   qlakeo  ...    0.000000

Variable    ...      StdDev
0    hlink  ...    0.000197
1   qlink1  ...    0.011093
2     cvol  ...  278.624000
3    resht  ...    0.000000
4   qlakeo  ...    0.000000

Variable    ...       StdDev
0    hlink  ...     0.000328
1   qlink1  ...     0.023870
2     cvol  ...  1705.840000
3    resht  ...     0.000000
4   qlakeo  ...     0.000000

Variable    ...       StdDev
0    hlink  ...     0.000242
1   qlink1  ...     0.022383
2     cvol  ...  1706.250000
3    resht  ...     0.000000
4   qlakeo  ...     0.000000

Variable    ...       StdDev
0    hlink  ...     0.000393
1   qlink1  ...     0.023891
2     cvol  ...  1706.960000
3    resht  ...     0.000000
4   qlakeo  ...     0.000000