Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when dt/dtrt_ch is not an integer #628

Open
jmccreight opened this issue Oct 9, 2015 · 2 comments
Open

when dt/dtrt_ch is not an integer #628

jmccreight opened this issue Oct 9, 2015 · 2 comments

Comments

@jmccreight
Copy link
Collaborator

I dont know if this is important to flag or not.
I was running LSM DT = 900 sec and DTRT_CH = 120 sec. I'm not sure what the ouput files were really representing (I assume the channel state 1 minute later was being written to the file, because I didnt notice any correction of DTRT_CH, but I didnt look very hard).

For my branch I added this to Data_Rec/module_namelist.F

if(DT/nlst%DTRT_CH .ne. real(int(DT) / int(DTRT_CH)) ) &
     call hydro_stop("driveChannelRouting: DT not a multiple of DTRT_CH")

If you like it add it to master, otherwise, ignore it and close issue.

@weiyu11
Copy link

weiyu11 commented Oct 10, 2015

The WRF-Hydro is driven by Land surface model. It is incorrect if the
routing time step is bigger than land surface model.

For coupled with WRF, we have a check and automatic set the routing to
be <= land surface time step. In offline, we do not have this setting.
However, in future, we need to add functions for checking the namelist
parameters, just as what WRF did now.

Wei

On 10/9/15, 4:05 PM, James McCreight wrote:

I dont know if this is important to flag or not.
I was running LSM DT = 900 sec and DTRT_CH = 120 sec. I'm not sure
what the ouput files were really representing (I assume the channel
state 1 minute later was being written to the file, because I didnt
notice any correction of DTRT_CH, but I didnt look very hard).

For my branch I added this to Data_Rec/module_namelist.F

|if(DT/nlst%DTRT_CH .ne. real(int(DT) / int(DTRT_CH)) ) &
call hydro_stop("driveChannelRouting: DT not a multiple of DTRT_CH")
|

If you like it add it to master, otherwise, ignore it and close issue.


Reply to this email directly or view it on GitHub
#628.

@weiyu11
Copy link

weiyu11 commented Oct 10, 2015

On 10/9/15, 4:05 PM, James McCreight wrote:

I dont know if this is important to flag or not.
I was running LSM DT = 900 sec and DTRT_CH = 120 sec. I'm not sure
what the ouput files were really representing (I assume the channel
state 1 minute later was being written to the file, because I didnt
notice any correction of DTRT_CH, but I didnt look very hard).

For my branch I added this to Data_Rec/module_namelist.F

|if(DT/nlst%DTRT_CH .ne. real(int(DT) / int(DTRT_CH)) ) &
call hydro_stop("driveChannelRouting: DT not a multiple of DTRT_CH")|
|Forget to mention, you can put this check into a separate function,
just like WRF model. We will add others to the same function in the future.

Wei
|

|
|

If you like it add it to master, otherwise, ignore it and close issue.


Reply to this email directly or view it on GitHub
#628.

@rcabell rcabell transferred this issue from another repository May 6, 2022
@rcabell rcabell transferred this issue from another repository May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants