-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect variable types in routelink file result in inconsistent model behavior #40
Comments
Basically the new Route_Link.nc file that Joe (I think) created is causing model testing to fail, because of some weird model behavior when there are incorrect types in the Route_Link.nc file. James is reverting back to the old domain files for testing (and was going to add some checks in the code - to address this issue). I imagine the new files (probably were changed for a reason) will need to get fixed as well at some point. (edited) |
Yes, I edited the route_link for NWM to remove the errant gage that was present, and then re-saved the file. I did not pay attention to variable types because I thought that was handled by the netCDF standard. Is it not? |
This should be rolled up into an Input/Configuration Validation meta-issue. Tagging pending that issue being opened. |
Expected Behavior
If variable types are important, the model should check for them and notify the user
Current Behavior
The model is failing testing because of inconsistent behavior resulting from incorrect variable types in the new routelink file
Possible Solution
Add in checks for appropriate variable types and roll back testing to old model domain for the time being
@jmccreight has offered to add in checks for this
The text was updated successfully, but these errors were encountered: