-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect Thompson MP tracer count in GFS PBL generic pre/post run methods #880
Comments
in the PBL for Thompson microphysics scheme when coupling with prognostic aerosols (NCAR#880).
Does it affects uncoupled suites that is ice- and water-friendly aerosols, such as RRFS v1? |
ccpp-physics/physics/GFS_PBL_generic.F90 Lines 321 to 339 in 979324a
I don't expect this bug to have an impact on coupled/uncoupled configurations that do not include UFS-Aerosols. I would suggest refactoring microphysics-related code that includes assumptions on the number and location of microphysics tracers throughout CCPP physics suites. |
Would it be possible to add attributes to the tracers in the field_table to easier keep track whether a tracer should be vertically diffused in physics, advected in the dycore, etc? |
There is a new capability in |
Thanks Dom, I think such an approach would be very valuable, then these hard coded values could be replaced by values generated directly after reading the field table. |
Here are my 2 cents on the topic based on WRF experience. I believe that any bulk microphysics scheme's rain and graupel species should not be vertically diffused with PBL mixing coefficients as they should fall too fast to be affected by "diffusion" whereas the variables of: cloud ice (mass and number?), cloud water (mass and number?), and aerosol variables should certainly have consistent mixing that is done for water vapor. It might be fair to say that snow is questionable since it has a fallspeed near 1 m/s, maybe it isn't necessary similar to rain/graupel. |
…v6_scidoc * 'main' of https://github.com/NCAR/ccpp-physics: fix the missing value of fv in vege_flux Revert "Lsm upgrades mynn for p8c" put a upper/lower limit on cwpc Driver update, opt_trs=4 over vegetation, and z0hover bare soil etc. modify a table of cwp parameter modify a table of cwp parameter modify a table of cwp parameter modify a table of cwp parameter revert back to shdfac in gvfun calculation due to occasional model crash tuning cd/lm parameter tuning cd/lm parameter Noah MP non-glacier changes for MYNN Noah MP glacier changes for MYNN Noah MP driver and meta changes for MYNN modify the eddy diffusivity for heat at the top of the canopy replace shdfac by fveg for zvfun Properly set the total number of species to be diffused in the PBL for Thompson microphysics scheme when coupling with prognostic aerosols (NCAR#880). further refinement of the impact of vegetation on zvfun correct the condition to avoid a divide by zero exception add Chunxi Zhang to CODEOWNERS revert the df1 change due to some negative impact on surface temperature to avoid exception floating point simplify the code with internal function maxval replace fveg by lai/laimax to be used for dependent to read new hig-res ice climatology data correct the reference height gvf impact on thermal conductivity limited to the first soil layer add some groundwater mods from ncar code add some clean up to energy fix missing czil1 in vege_flux move trs options to sfcdif3 change fveg to shdfac in sfcdif3 vege call add sfcdif3 as a separate subroutine add canopy heat storage and gvf impact on thermal conductivity minor formatting update scm_sfc_flux_spec scheme to set some variables needed by non-surface physics canopy height dependant czil change czil set up option for thermal roughness
Description
The total number of tracers in Thompson microphysics is incorrectly returned by set_aerosol_tracer_index():
ccpp-physics/physics/GFS_PBL_generic.F90
Lines 37 to 43 in 979324a
which is used in GFS_PBL_generic_pre_run() and GFS_PBL_generic_post_run() if PBL mixing is enabled for atmospheric tracers (
trans_aero = (trans_trac .and. cplchm) = .true.
).The proper number may be found in noaa-emc/fv3atm/ccpp/data/GFS_typedef.F90:
This bug affects prototype 8b as it features both Thompson MP and prognostic aerosols.
The text was updated successfully, but these errors were encountered: