Enable compiling LISF on Cray/SLES 15.4/PrgEnv 8.3.3 using Intel 2022.2.1 compilers #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I replaced '-nomixed_str_len_arg' with '-nomixed-str-len-arg'.
The OS upgrade on narwhal changed the available low level RPC library. The system no longer has a static version to compile into the HDF4 library. You must now specify the RPC library in the LDFLAGS variable (both when building the HDF4 library itself and when compiling LISF). This OS upgrade is also missing a symbolic link to libtirpc.so. This commit tweaks the use of the LDT_RPC, LIS_RPC, and LVT_RPC environment variables. If these environment variables are defined, then they must be set to the full file name of the tirpc library (e.g., /lib64/libtirpc.so.3). Then the build scripts will add this library to the LDFLAGS variable for HDF4. If these environment variables are not defined, then the build scripts function as before (nothing new is added to the LDFLAGS variable for HDF4). Also see commit f50ddd2.
|
This also addresses Issue #911 |
|
Code compiles when using user_557ww.cfg. However, the new Intel C compiler objects to code in RDHM and one of the VIC LSMs (missing function prototypes). Since these are not used by USAF and will not be used on Narwhal, I will go ahead and approve the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These changes address issues encountered when compiling LISF on narwhal after its upgrade to Cray/SLES 15.4/PrgEnv 8.3.3.