Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nldas2 and 3 collection and discovery config #157

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Add nldas2 and 3 collection and discovery config #157

merged 3 commits into from
Jul 31, 2024

Conversation

slesaad
Copy link
Member

@slesaad slesaad commented Jul 25, 2024

No description provided.

@slesaad slesaad requested a review from smohiudd as a code owner July 25, 2024 18:28
@slesaad slesaad requested a review from anayeaye July 25, 2024 18:28
anayeaye
anayeaye reviewed Jul 25, 2024
View reviewed changes
Copy link
Contributor

@anayeaye anayeaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something still seems a bit off on the color_map in renders (in addition to the param change)

ingestion-data/staging/collections/nldas2.json Show resolved Hide resolved
ingestion-data/staging/collections/nldas3.json Show resolved Hide resolved
@slesaad
Copy link
Member Author

slesaad commented Jul 30, 2024

Something still seems a bit off on the color_map in renders (in addition to the param change)

It seems fine based on this:
https://github.com/NASA-IMPACT/veda-config/blob/bd93b315b0a9d675a2634c12cdb702bcb9189c97/datasets/geoglam.data.mdx?plain=1#L31

anything in particular you're concerned about?

@anayeaye
Copy link
Contributor

Something still seems a bit off on the color_map in renders (in addition to the param change)

It seems fine based on this: https://github.com/NASA-IMPACT/veda-config/blob/bd93b315b0a9d675a2634c12cdb702bcb9189c97/datasets/geoglam.data.mdx?plain=1#L31

anything in particular you're concerned about?

@slesaad I mistakenly thought that parameter name was why the rendered preview didn't work for these collections. The rendered preview support in the stac-api needs to be updated for the recent breaking changes to titiler-pgstac. I opened an issue for that NASA-IMPACT/veda-backend#406

@slesaad slesaad merged commit 1a8b557 into main Jul 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smohiudd smohiudd smohiudd approved these changes

@anayeaye anayeaye anayeaye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slesaad @anayeaye @smohiudd