Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add playwright #363

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

add playwright #363

wants to merge 7 commits into from

Conversation

stephenkilbourn
Copy link

@stephenkilbourn stephenkilbourn commented Feb 1, 2024

What am I changing and why

This adds a playwright test suite that generates a list of every catalog and story on the /data-catalog and /stories routes. It ensures that the pages render with the name and that there are no javascript errors on those pages. It is dependent on the changes to the `veda-ui located in NASA-IMPACT/veda-ui#835

A follow-up PR can add the github workflow to trigger the test run on each PR once that veda-ui PR is merged. The veda-config will also need a mapbox token added as a github secret.

How to test

run the yarn install to pull in the new dependencies. Run the script yarn test:e2e to verify that the tests run locally.** To verify that tests catch errors, modify pages to break them and ensure that the test suite finds the failure.

** you may be asked to install the playwright browsers on the first run of the test suite.

⚠️ Checks

Copy link

netlify bot commented Feb 1, 2024

Deploy Preview for visex ready!

Name Link
🔨 Latest commit b5c6c75
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/66577554d763680007a829b9
😎 Deploy Preview https://deploy-preview-363--visex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant