Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Protocols for most base classes #150

Merged
merged 6 commits into from
May 7, 2023
Merged

Add Protocols for most base classes #150

merged 6 commits into from
May 7, 2023

Conversation

N-Wouda
Copy link
Owner

@N-Wouda N-Wouda commented May 7, 2023

This PR:

Notes:

  • It is essential that you add a test when making code changes.
    This keeps the code coverage level up, and helps ensure the changes work as intended.
  • When fixing a bug, you must add a test that would produce the bug in the master branch, and then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass the pre-commit workflow, which you can set up locally using pre-commit.
  • Docstring additions must render correctly, including escapes and LaTeX.

@codecov
Copy link

codecov bot commented May 7, 2023

Codecov Report

Merging #150 (fac6908) into master (936cd0c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #150   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines          668       665    -3     
=========================================
- Hits           668       665    -3     
Impacted Files Coverage Δ
alns/ALNS.py 100.00% <100.00%> (ø)
alns/State.py 100.00% <100.00%> (ø)
alns/accept/AcceptanceCriterion.py 100.00% <100.00%> (ø)
alns/accept/GreatDeluge.py 100.00% <100.00%> (ø)
alns/accept/HillClimbing.py 100.00% <100.00%> (ø)
alns/accept/LateAcceptanceHillClimbing.py 100.00% <100.00%> (ø)
alns/accept/RandomWalk.py 100.00% <100.00%> (ø)
alns/accept/RecordToRecordTravel.py 100.00% <100.00%> (ø)
alns/accept/SimulatedAnnealing.py 100.00% <100.00%> (ø)
alns/accept/WorseAccept.py 100.00% <100.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@N-Wouda N-Wouda merged commit 9a03619 into master May 7, 2023
@N-Wouda N-Wouda deleted the protocols branch May 7, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protocols for AcceptanceCriterion and WeightScheme
1 participant