Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temp disable shared_object_transaction test #1603

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Temp disable shared_object_transaction test #1603

merged 1 commit into from
Apr 27, 2022

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Apr 27, 2022

The test seems to be always stuck

@lxfind lxfind enabled auto-merge (squash) April 27, 2022 01:02
@huitseeker
Copy link
Contributor

isn't this what #1601 is meant to address?

@lxfind
Copy link
Contributor Author

lxfind commented Apr 27, 2022

isn't this what #1601 is meant to address?

I am not sure. Maybe? It can always turn this back if it's fixed there.

@asonnino
Copy link
Contributor

isn't this what #1601 is meant to address?

I am not sure. Maybe? It can always turn this back if it's fixed there.

No #1601 is fixing something else. But this is very strange because the test works fine on my local machine (so it is hard to debug on the CI)

@lxfind lxfind merged commit 847b6c2 into main Apr 27, 2022
@lxfind lxfind deleted the temp-disable-shared-tests branch April 27, 2022 01:25
@lxfind
Copy link
Contributor Author

lxfind commented Apr 27, 2022

I can repro on my Mac. I will try to take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sblackshear sblackshear sblackshear approved these changes

@asonnino asonnino Awaiting requested review from asonnino

@todd-mystenlabs todd-mystenlabs Awaiting requested review from todd-mystenlabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lxfind @huitseeker @asonnino @sblackshear