P0 [dev.net] - Allow hostnames to be parsed for Narwhal config

[velvia]

Quick review - allow hostnames to be used for Narwhal and Genesis/network configuration, not just IP addresses.

This is needed for AWS dev.net deployment (using local domain names, like in K8s, instead of fixed IPs)

[bmwill]

looking at this I'm fairly confused on why this would be needed. this did work at some point so maybe there's something misconfigured in the environment you're running in?

[velvia]

@bmwill sorry the code was wrong, hopefully the new code will make it a bit more clear. The to_socket_addrs() function returns an Iter of addresses, it's not at all the same as the old parse() method.

parse() does not work with hostnames. It gives the same error as I got in a container:

thread 'rest_server_tests::test_concurrency' panicked at 'called `Result::unwrap()` on an `Err` value: AddrParseError(())', sui/src/config.rs:106:49
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I have changed the default hostname to localhost which did not work before in tests.