[Faucet] Config for host and port #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mystenmark
approved these changes
Apr 25, 2022
faucet/src/main.rs
Outdated
| about = "Faucet for requesting test tokens on Sui", | ||
| rename_all = "kebab-case" | ||
| )] | ||
| struct ServerConfig { |
There was a problem hiding this comment.
Can you call this FaucetConfig instead?
|
LGTM, in the script that calls this we can add in an env var support for configuring ports. |
9b538a8
to
f182d99
Compare
f182d99
to
33d49d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.