Add Tasker integrations #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b3f795a
to
0373f82
Compare
|
Hi thanks for the PR! I will definitely take a closer look later. |
0373f82
to
39639a6
Compare
Mygod
reviewed
Aug 6, 2024
Mygod
reviewed
Aug 6, 2024
39639a6
to
2941b10
Compare
|
I'll take over and fix the rest. Thanks! Please don't force push again. :) |
Mygod
approved these changes
Aug 6, 2024
|
Just made a change to remove the |
|
I can't merge this myself since I don't have write access. |
|
This PR is now merged. It will go into the next beta release (v2.18.0). Thanks again! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use-case for VPN Hotspot that requires enabling USB tethering automatically when USB is connected. I can't use the developer option to have my default USB configuration be USB tethering, since my plan has no hotspot support at all. I did try using Tasker to enable USB tethering manually, but wasn't really getting anywhere. VPN Hotspot would show it being active but no traffic would be passed.
Since I've seen some other requests for automation, and it comes in handy for me, I decided to add Tasker Plugin support to VPN Hotspot. These are the features I implemented:
Actions
Using the configuration button in Tasker will toggle whether the action will enable or disable tethering. This isn't the best UI, but I think it might be preferable to implementing a new Activity just to show a single toggle. I'm definitely open to other opinions.
State Actions
%wifi%usb%ethernet%bluetoothState Events