Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MCR-3125 Set type of parameter value field to TEXT/CHARACTER VARYING #2174

Open
wants to merge 2 commits into
base: 2023.06.x
Choose a base branch
from
Open

MCR-3125 Set type of parameter value field to TEXT/CHARACTER VARYING #2174

wants to merge 2 commits into from

Conversation

Possommi
Copy link
Contributor

@Possommi Possommi commented Jun 10, 2024 •
edited by jira bot
Loading

@Possommi Possommi force-pushed the issues/MCR-3125-The-length-of-MCRJob-parameter-values-should-not-be-limited-to-255 branch from 7260fa6 to 265da24 Compare June 17, 2024 10:16
@Possommi Possommi changed the title MCR-3125 Set max length to MCRJob parameter value to 16384 MCR-3125 Set type of parameter value field to TEXT/CHARACTER VARYING Jun 17, 2024
kkrebs
kkrebs requested changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@kkrebs kkrebs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need migration step, so this should be a change in main branch

@yagee-de
Copy link
Member

yagee-de commented Jul 3, 2024

MS SQL Server

The ntext, text, and image data types will be removed in a future version of SQL Server. Avoid using these data types in new development work, and plan to modify applications that currently use them.

– Source

@yagee-de
Copy link
Member

yagee-de commented Jul 3, 2024

Type „TEXT“ is also not part of SQL or JDBC standard – but present in many DBMS. So I would prefer to make reasonable big VARCHAR out of it. "columDefinition" also makes this not portable as this definition is used on every DBMS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrebs kkrebs kkrebs requested changes

@sebhofmann sebhofmann sebhofmann approved these changes

@adlerre adlerre Awaiting requested review from adlerre

@toKrause toKrause Awaiting requested review from toKrause

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Possommi @yagee-de @kkrebs @sebhofmann