Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]关于读取easyscholar接口数据时忽略了自定义数据集的问题 #407

Closed
Rphone opened this issue May 2, 2023 · 1 comment
Closed

[bug]关于读取easyscholar接口数据时忽略了自定义数据集的问题 #407

Rphone opened this issue May 2, 2023 · 1 comment

Comments

@Rphone
Copy link
Contributor

Rphone commented May 2, 2023 •
edited
Loading

类似的问题在Issue #363 有提到过，经过分析代码发现
在src/modules/utils.ts 第29行开始解析easyscholar接口的数据，当读取easyscholar官方数据集为null时，
代码第37行直接return 0;，此时如果用户的自定义数据集有数据返回的话会得不到解析的机会
事实上对于很多会议类的文章，由于会议通常带简写和年份，官方数据集很难直接匹配到，因此很多人倾向于用可以模糊匹配的自定义数据集（例如CCF）才更为准确，我自己尝试修复了这个问题，准备提交一个PR，如果您觉得合适的话可以考虑合并

修复前
image
修复后的效果
image
@Rphone Rphone closed this as completed May 2, 2023
Rphone added a commit to Rphone/zotero-style that referenced this issue May 2, 2023
@Rphone
fix: resolved issue MuiseDestiny#407
ee2234d
@Rphone Rphone changed the title [bug] [bug]关于读取easyscholar接口数据时忽略了自定义数据集的问题 May 2, 2023
@Rphone Rphone reopened this May 2, 2023
@Rphone Rphone mentioned this issue May 2, 2023
Merged
MuiseDestiny added a commit that referenced this issue May 3, 2023
@MuiseDestiny
Merge pull request #408 from Rphone/master
00bee9a 
fix: resolved issue #407
@MuiseDestiny
Copy link
Owner

感谢贡献！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rphone @MuiseDestiny