[pull] master from guillaumechereau:master #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that the import works better on Unreal Engine.
The inkscape export call was not working anymore. Use cairosvg instead now.
Not very useful I think.
It is broken, and I don't think we need it anyway.
Properly pass the target count as argument instead of setting it to zero.
Trying to make the style of the app a bit more modern, while also simplifying the UI code. - Redo all the icons with a flatter style. - Redo both the dark and light theme. Remove the original 'dark green' theme for now. - Put the windows on top of the 3d view, instead of the view being a separate window.
Add meshoptimizer and boostrap icons.
Makes the code a bit cleaner like that.
Still a bit experimental.
The color lightning effect was too strong.
Not tested much.
Cannot use drag for delta operations.
Later should probably add the option to manually specify the origin.
We should not assume that the material pointer is not changing. Should we replace it with an index maybe?
Will need to make sure this does not affect the performances, since this work by computing the hash of the image at each frame!
So that we can control the size/position with the rest of the UI elements.
Since we reset the input string for imgui. Maybe we should simplify this.
So that we can later add more options from it.
* Initialize graphics context in png_export * Signed declaration
Fix grammar a bit, and remove example about splitting commits into smaller chunks, since I don't want people to overdo it either.
So that we can remove some clutter in the tools panel.
Without this the padding was slightly larger in layers compared with other lists.
Because I would like to support auto registered filters, with optionaly shortcuts, but without having to manually add an action for each of them. I replaced the fixed size array with an stb array that can dynamically grow. Untested.
Filters are a bit similar to tools, with a few difference: - they only have a UI callback, but no ability to draw (for now at least). - They don't require any icon or fixed action id, so we can more easily add filters: just need to add a c file with the FILTER_REGISTER macro. - They show up in a special menu, instead of in the tool panel. The idea is to use the filters for operations that don't require a full drawing tool, like color correction, voxel effects, etc. Still a work in progress.
* Implement layer wrapping * Make the wrap panel reusable * Better name for the "wrap box" * Support wrapping the selection * Fix image history after wrapping selection * Only show wrap panel for visible layers * Move the wrap box to a new filter * Tweak the wrap GUI a bit * Implement the wrap filter * Remove unused function
Volume.h should only have very low level function. Here I moved the function directly in the wrap filter, since this is a function very specific to this filter. Also fixed the code style a bit: moved variable declarations at the top of the function, and fixed compilation warning.
Not needed anymore since we have the 'wrap' filter now that can be used as an example.
As a better way to get the user config directory. Still experimental, but the idea is that it should later allow to have several directory for things like scripts, palettes, etc. Might break some stuffs in the code.
Looks cleaner like that.
I prefer it like that, trying to follow the convention that all functions from a given module should start with the module name.
Untested for now, since I did this on a Mac. This works by iterating /etc/goxel from sys_iter_paths with SYS_LOCATION_CONFIG. Would probably need to add some options to this function to specify if we want to skip non present or non readable directories.
gcc doesn't like when we use snprintf to concatenate buffers that can maybe truncate the result. Fix that by lowering the max path size for directories only. Not very clean but I am not sure how to fix that in a better way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )