You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix stage overview caret icon positioning
Bug:
When the stage overview for the rightmost pipeline on the
dashboard is opened, the overview caret icon is mis-positioned
initially and on the subsequent redraw its positioned appropriately.
Why did it happen?:
The 'shouldAlignLeft' state was changed in the oncreate
lifecycle method, whereas, any state changes done in the oncreate
does not performs an immediate redraw. Such changes will be
reflected on the next periodic redraw.
This behavior caused the caret icon to be positioned
appropriately on the subsequent redraws.
Fix:
Do not store/update state as part of the oncreate method.
As we've the handle to the created element's DOM, add appropriate
classes to the DOM element within oncreate.
Revert "Merge pull request gocd#8177 from kritika-singh3/remove-empty…
…-task-list-validation"
This reverts commit e63a99a, reversing
changes made to a82dee7.
- this is reverted as the validation makes sense.