dump ris properly when tag is delimited but not a list tag #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shapiromatron
requested changes
Jul 14, 2023
J535D165
approved these changes
Jul 17, 2023
shapiromatron
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a tag is marked as delimited but not a list tag, the parser will read it in as a list, but will only a single tag (i.e. if the tag is repeated it will be skipped). This was added in #52
If the writer encounters a list tag, whether it is delimited or not, it will write multiple keys. This PR fixes the case where a tag is delimited but not a list tag. Logic was added to re-combine the values of the list with the provided delimiter.
This PR also replaces some hard-coded tags with class variables.