Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce cursor for serialization #227

Merged
merged 2 commits into from
Dec 12, 2023
Merged

refactor: introduce cursor for serialization #227

merged 2 commits into from
Dec 12, 2023

Conversation

MrCroxx
Copy link
Owner

@MrCroxx MrCroxx commented Dec 12, 2023

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

This PR introduces trait Cursor for serialization to reduce buffer copy.

It will be used in further PRs.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have passed make check and make test or make all in my local envirorment.

Related issues or PRs (optional)

#216 #226

@MrCroxx MrCroxx added the feature New feature or request label Dec 12, 2023
@MrCroxx MrCroxx self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (fb5cd5e) 77.37% compared to head (4b2762a) 76.38%.

Files Patch % Lines
foyer-common/src/code.rs 0.00% 74 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #227      +/-   ##
==========================================
- Coverage   77.37%   76.38%   -1.00%     
==========================================
  Files          47       47              
  Lines        5685     5759      +74     
==========================================
  Hits         4399     4399              
- Misses       1286     1360      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MrCroxx MrCroxx merged commit 4d38f4a into main Dec 12, 2023
11 checks passed
@MrCroxx MrCroxx deleted the xx/cursor branch December 12, 2023 09:02
Copy link
Collaborator

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants