build(idea): base run configs on Gradle #5257
Conversation
As a result of looking into #5256 I propose to make our run configurations use Gradle instead of IntelliJ's built-in build system.
There was a problem hiding this comment.
The main Terasology run task still seems to work for me. I have observed that the other presets are present in the correct folders from the run menu. It might be possible to be more generous with the -Xms and -Xmx JVM options now but that can be evalulated another time.
| @@ -0,0 +1,25 @@ | |||
| <component name="ProjectRunConfigurationManager"> | |||
| <configuration default="false" name="Terasology (EXTREME)" type="GradleRunConfiguration" factoryName="Gradle"> | |||
There was a problem hiding this comment.
The old name for this configuration was "Extreme (8GB)", which I think was clearer. The reason why this preset was "extreme" was because at the time 8GiB of memory was likely to consume the majority of available memory in your system. Things have moved on a bit now, such that this isn't as extreme as it once was but it is still a good test.
There was a problem hiding this comment.
renamed to terasology (8gb)
| <option value="--args='--homedir=. --no-crash-report'" /> | ||
| </list> | ||
| </option> | ||
| <option name="vmOptions" value="-Xms256m -Xmx1536m -XX:+UnlockCommercialFeatures -XX:+FlightRecorder -XX:+UnlockDiagnosticVMOptions -XX:+DebugNonSafepoints -XX:StartFlightRecording=filename=terasology.jfr,dumponexit=true" /> |
There was a problem hiding this comment.
I think that -XX:+UnlockCommercialFeatures is no longer needed and might actually not work anymore. JDK Flight Recorder has been a part of OpenJDK for a long time now and that flag was only ever needed for old versions of the Oracle JDK.
There was a problem hiding this comment.
this gave an error, pushed a fix by removing it.
Co-authored-by: BenjaminAmos <[email protected]>
|
doc update: not sure which one you mean. checked https://github.com/MovingBlocks/Terasology/blob/develop/docs/Contributor-Quick-Start.md which looks ok. |
| @@ -0,0 +1,25 @@ | |||
| <component name="ProjectRunConfigurationManager"> | |||
| <configuration default="false" name="CLI Help" type="GradleRunConfiguration" factoryName="Gradle"> | |||
There was a problem hiding this comment.
| <configuration default="false" name="CLI Help" type="GradleRunConfiguration" factoryName="Gradle"> | |
| <configuration default="false" name="Terasology (CLI Help)" type="GradleRunConfiguration" factoryName="Gradle"> |
Contains
As a result of looking into #5256 I propose to make our run configurations use Gradle instead of IntelliJ's built-in build system.
How to test
Try out the different configurations, and observe wheter anything changes drastically from the previous run configuration behavior.
Let me know whether you are missing a configuration you are using often and that was removed in this PR.
Outstanding before merging