Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close a tab on every error #359

Merged
merged 1 commit into from
Aug 25, 2019
Merged

Close a tab on every error #359

merged 1 commit into from
Aug 25, 2019

Conversation

ziflex
Copy link
Member

@ziflex ziflex commented Aug 24, 2019

Closes #357

@ziflex ziflex added type/bug Something isn't working area/stdlib Standard library issue area/drivers/cdp Cdp driver area/drivers HTML drivers labels Aug 24, 2019
@ziflex ziflex requested a review from 3timeslazy August 24, 2019 23:28
@codecov
Copy link

codecov bot commented Aug 24, 2019 •
edited
Loading

Codecov Report

Merging #359 into master will decrease coverage by <.1%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           master    #359     +/-   ##
========================================
- Coverage    39.8%   39.8%   -<.1%     
========================================
  Files         218     218             
  Lines        8711    8713      +2     
========================================
  Hits         3467    3467             
- Misses       4893    4895      +2     
  Partials      351     351

@ziflex ziflex merged commit 70b17ce into master Aug 25, 2019
@ziflex ziflex deleted the bugfix/closing-tab-on-error branch August 25, 2019 00:26
@bundleman bundleman mentioned this pull request Sep 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3timeslazy 3timeslazy Awaiting requested review from 3timeslazy

Assignees
No one assigned
Labels
area/drivers/cdp Cdp driver area/drivers HTML drivers area/stdlib Standard library issue type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not close tab when the page load times out
1 participant
@ziflex