Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CONTRIBUTING.md nuance: non-string environment variables #254

Closed
seporterfield opened this issue Jul 6, 2024 · 0 comments
Closed

Add CONTRIBUTING.md nuance: non-string environment variables #254

seporterfield opened this issue Jul 6, 2024 · 0 comments
Assignees
@seporterfield
Labels
[ documentation / Improvements or additions to documentation

Comments

@seporterfield
Copy link
Collaborator

seporterfield commented Jul 6, 2024 •
edited
Loading

Problem

CONTRIBUTING.md is missing info about adding new non-string environment variables as mentioned in #240

Solution

Add docs

#240 Better fix: account for empty strings before converting directly in settings.py.
Closing since this isn't a docs issue.
@seporterfield seporterfield added the [ documentation / Improvements or additions to documentation label Jul 6, 2024
@seporterfield seporterfield self-assigned this Jul 6, 2024
@seporterfield seporterfield closed this as not planned Won't fix, can't repro, duplicate, stale Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seporterfield seporterfield

Labels
[ documentation / Improvements or additions to documentation
Projects
Rebutify's MVP
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seporterfield