added pagination for arguments

[purple-void]

we also added some comments

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rebutify	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 7, 2024 0:11am

[Monstarrrr]

1. Why are we making pagination for arguments specifically? Isn't pagination the same logic regardless of the type of content?
   Use django setting to apply to any endpoint

2. The front-end should be able to decide on how many items per page there are. Do not hard-code it in the back-end unless as a default value

[purple-void]

@Monstarrrr we changed pagination to apply globally. PAGE_SIZE is set in env. Does that work for the front-end?

[seporterfield]

commented 2 changes
looks great and nice job!

[purple-void]

failed? boooo

[purple-void]

@seporterfield we think the checks are wrong. we can't reproduce the error in our code

[seporterfield]

@seporterfield we think the checks are wrong. we can't reproduce the error in our code

did you read the error/output of the checks?

[purple-void]

@seporterfield we think the checks are wrong. we can't reproduce the error in our code

did you read the error/output of the checks?

"PAGE_SIZE": int(os.getenv("PAGE_SIZE", 10)),
ValueError: invalid literal for int() with base 10: ''

We get this error only here with GitHub actions. PAGE_SIZE is '' here. That doesn't happen in our code. This would be fixed if PAGE_SIZE was set in the workflow file.

[seporterfield]

The way we're parsing .env variables has a side effect of any empty variables in .env being parsed as the empty string instead of None which is kinda annoying but I haven't been able to find a solution that doesn't make things even harder for people trying to use our project.

Fix:
Make PAGE_SIZE=20 in .template-env
For now any variables pulled in from .env that need a type conversion will have to have a set default in .template-env
Otherwise the conversion will fail or have unintended behavior since it's trying to convert from an empty string.

[purple-void]

Fix: Make PAGE_SIZE=20 in .template-env For now any variables pulled in from .env that need a type conversion will have to have a set default in .template-env Otherwise the conversion will fail or have unintended behavior since it's trying to convert from an empty string.

We fixed it for now with "PAGE_SIZE": int(os.getenv("PAGE_SIZE", "10") or "10")

[seporterfield]

We fixed it for now with "PAGE_SIZE": int(os.getenv("PAGE_SIZE", "10") or "10")

this is probably the best long term strategy for non-string env vars, looks great

[purple-void]

we deleted endpoints with parameters (except for page_size) as they weren't relevant to this branch, and @Monstarrrr decided on different endpoints. will implement those in a new branch

[Monstarrrr]

To the rescue