Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify API ViewSet: arguments with pagination #135

Closed
2 tasks
seporterfield opened this issue Jun 5, 2024 · 3 comments · Fixed by #240
Closed
2 tasks

Modify API ViewSet: arguments with pagination #135

seporterfield opened this issue Jun 5, 2024 · 3 comments · Fixed by #240
Assignees
@purple-void
Labels
[ back-end / feature Functionality or significant enhancement for the project

Comments

@seporterfield
Copy link
Collaborator

seporterfield commented Jun 5, 2024 •
edited by Monstarrrr
Loading

Create/Modify an API ViewSet that gets arguments with pagination (get 10 arguments, get 25 arguments, get 50, get 100)

  • Tests written
  • Tests passing

EDIT:
The "create" part has been completed in #216.
The "modify" part is to be done here still
@seporterfield seporterfield added [ back-end / feature Functionality or significant enhancement for the project labels Jun 5, 2024
@purple-void purple-void self-assigned this Jun 5, 2024
@seporterfield seporterfield changed the title Arguments API function with pagination Create/modify API ViewSet: arguments with pagination Jun 5, 2024
@Monstarrrr
Copy link
Owner

Create/modify an API ViewSet that gets arguments with pagination (get 10 arguments, get 25 arguments, get 50, get 100)

  • Tests written
  • Tests passing

Just to be clear, pagination would be a fixed number of arguments at different locations of the array of data, you don't increase the amount of data in the API answer. There is a parameter we could set to increase how much we want to be displayed per page, but that is something else.

@purple-void
Copy link
Collaborator

@seporterfield what do you mean tests written and tests passing?

@seporterfield
Copy link
Collaborator Author

The new features for this issue will have the corresponding tests

@purple-void purple-void changed the title Create/modify API ViewSet: arguments with pagination Create/modify API ViewSet: arguments with pagination EDIT: Create has been completed Jun 26, 2024
@purple-void purple-void linked a pull request Jul 2, 2024 that will close this issue
added pagination for arguments #240
Merged
@Monstarrrr Monstarrrr changed the title Create/modify API ViewSet: arguments with pagination EDIT: Create has been completed ~~Create~~/modify API ViewSet: arguments with pagination Jul 3, 2024
@Monstarrrr Monstarrrr changed the title ~~Create~~/modify API ViewSet: arguments with pagination Modify API ViewSet: arguments with pagination Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@purple-void purple-void

Labels
[ back-end / feature Functionality or significant enhancement for the project
Projects
Rebutify's MVP
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added pagination for arguments Monstarrrr/rebutify
3 participants
@Monstarrrr @seporterfield @purple-void