Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android high-frequency touch events #8109

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

Mindfulplays
Copy link
Contributor

  • Look up ACTION_MOVE historical events if EnableHighFrequencyTouch is true and plumb it through the TouchPanel.

@tomspilman @SimonDarksideJ @harry-cpp Please take a look.

.editorconfig Outdated
insert_final_newline = true
trim_trailing_whitespace = true
# ReSharper properties
resharper_indent_inside_namespace = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonDarksideJ @harry-cpp @mrhelmut

Are these good changes to the editor config?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know what the resharper one does, but the rest is fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, shouldn't embed other product configuration inside MonoGame files, please remove @Mindfulplays

Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the rogue editor config and it's all good

.editorconfig Outdated
insert_final_newline = true
trim_trailing_whitespace = true
# ReSharper properties
resharper_indent_inside_namespace = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, shouldn't embed other product configuration inside MonoGame files, please remove @Mindfulplays

@Mindfulplays
Copy link
Contributor Author

Mindfulplays commented Dec 31, 2023

I can do that but I wanted to explain what it does:

It formats the classes inside a namespace, and uses proper indentation for the rest of the code per Monogame guidelines. I have been using this heavily to autoformat stuff I touch.

If it doesn't make sense, I can remove it... but frankly every time I touch files the existing indentation is all over the place especially tabs vs spaces so have been trying to clean up as we go...

I can add the vs code equivalent too later on.
Lmk!

@Mindfulplays
Copy link
Contributor Author

Removed .editorconfig changes. Rebased to latest develop - PTAL, thanks. @SimonDarksideJ

Copy link
Contributor

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Mindfulplays
As to the editor config, applying the styling on your side is fine, just don't force your styling approach into the base as everyone uses different tools :D

@SimonDarksideJ SimonDarksideJ merged commit 9a8f76f into MonoGame:develop Jun 17, 2024
4 checks passed
@Mindfulplays Mindfulplays deleted the android-touch branch June 17, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants