Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Pydantic v1/v2 dual-compatibility #787

Merged
merged 7 commits into from
Nov 8, 2023

Conversation

mattwthompson
Copy link
Contributor

@mattwthompson mattwthompson commented Nov 7, 2023

Description

This is my attempt at taking #736 over the finish line

Changelog description

Status

  • Code base linted
  • Ready to go

closes #736

Copy link
Collaborator

@loriab loriab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@mattwthompson mattwthompson marked this pull request as ready for review November 8, 2023 05:33
@loriab
Copy link
Collaborator

loriab commented Nov 8, 2023

I don't have official powers here at qcf, so merge decision/schedule is all @bennybp .

@bennybp
Copy link
Contributor

bennybp commented Nov 8, 2023

Thanks! I also removed the pins in some testing environments.

I remember there being some error with pydantic-settings being a separate package. Has that changed recently? It isn't in the dependency lists but everything seems to work

@mattwthompson
Copy link
Contributor Author

My guess is you're thinking of this issue: MolSSI/QCElemental#312

In which case it's still a problem, but under the umbrella of changes required to leverage the v2 API. Since this just allows access to v1 via v2 I think that can still be pushed into the future.

@bennybp
Copy link
Contributor

bennybp commented Nov 8, 2023

Oh yes, of course :) Thanks for finishing this up!

@bennybp bennybp merged commit e4910c3 into MolSSI:main Nov 8, 2023
17 checks passed
@mattwthompson
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants