Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI for py312 #433

Merged
merged 41 commits into from
Oct 30, 2023
Merged

CI for py312 #433

merged 41 commits into from
Oct 30, 2023

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Oct 24, 2023 •
edited
Loading

Description

  • Fix up as much as I could find for python 3.12, including raw strings and qcenginerecords
  • Add some windows testing to the GHA, c-f nwchem, py312.
  • A lot of the GHA iterations here were what identified windows+psi4+util.execute+(py312?) problems solved by change default jobs_per_node and intel cpu_cnt #417

Changelog description

Status

  • Code base linted
  • Ready to go

@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

Merging #433 (bde053c) into master (3f91816) will decrease coverage by 0.07%.
The diff coverage is 38.46%.

Additional details and impacted files

@loriab loriab changed the title rehabilitate CI CI for py312 Oct 27, 2023
@loriab loriab marked this pull request as ready for review October 27, 2023 18:15
WardLT
WardLT approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@WardLT WardLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loriab loriab merged commit 1e771c6 into MolSSI:master Oct 30, 2023
18 checks passed
@loriab loriab deleted the rehab branch October 30, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WardLT WardLT WardLT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loriab @WardLT