Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdsuite testing remp2, oo, dfcc #375

Merged
merged 11 commits into from
Aug 16, 2022
Merged

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Jul 30, 2022

Description

This pairs with psi4/psi4#2633. It doesn't affect QCEngine's general purpose, so I'll plan to mint a v0.24.1 with this when the Psi4 use is finalized.

Adds ref values for df ccsd, ccsd(t), a-ccsd(t), for orbital-optimized mp2, mp2.5, mp3, ccd, ccd(t), a-ccd(t), and for remp2 and oremp2. Existing reference values computed with Psi4's dfocc and occ modules have been updated now that it can converge tighter.

Changelog description

Status

  • Code base linted
  • Ready to go

@loriab loriab added the Testing Related to a testing enhancement or bug. label Jul 30, 2022
@codecov
Copy link

codecov bot commented Jul 30, 2022

Codecov Report

Merging #375 (c690762) into master (0d83304) will decrease coverage by 0.76%.
The diff coverage is 11.11%.

@loriab loriab mentioned this pull request Aug 1, 2022
11 tasks
Copy link
Collaborator

@WardLT WardLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't fully follow it, but it looks reasonable

@WardLT WardLT merged commit 1e24b4d into MolSSI:master Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Related to a testing enhancement or bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants