Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for NWChem #212

Merged
merged 3 commits into from
Jan 7, 2020
Merged

CI for NWChem #212

merged 3 commits into from
Jan 7, 2020

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Jan 6, 2020

closes #211

Description

try ubuntu's nwchem package, as recc by #211

Changelog description

  • Adds CI testing of NWChem 6.6 through Ubuntu xenial pkg

Questions

  • networkx is req'd for the NWChem interface for all but energies to align arrays, but at present it's only an optional requirement for qcel. There's a nice "install me" message, but in production users would probably like to know to install the pkg before the QC job, not after. But I'm hesitant to put the check in def found because if ppl are only looking at the boolean, it'd be unintuitive for which nwchem to be present but nwchem harness not be available. Where to address this? require networkx? or have a distinction btwn nwchem-found and nwchem-ready?
  • combine this CI lane with another?

Status

  • Code base linted
  • Ready to go

@loriab loriab added the Testing Related to a testing enhancement or bug. label Jan 6, 2020
@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #212 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@dgasmith
Copy link
Collaborator

dgasmith commented Jan 7, 2020

Awesome :)

FYI @WardLT

@dgasmith
Copy link
Collaborator

dgasmith commented Jan 7, 2020

We have a similar issue with the Orca interface where CCLib may be required. Should found be more complex where you can say something like found(binary_only=True)? Seems awkward however.

Copy link
Collaborator

@dgasmith dgasmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the codecov yaml isn't updated until a merge which is why we do not see a spike.

Please merge if you wish.

@loriab
Copy link
Collaborator Author

loriab commented Jan 7, 2020

maybe something like the below for when main QC present but non-QC component missing.

>>> Program information
Available programs:
dftd3 v3.2.1
mp2d v1.1

Incomplete programs (see devtools/conda-envs for install help):
nwchem -- needs networkx
orca -- needs cclib

Other supported programs:
cfour entos gamess molpro mopac nwchem openmm psi4 qchem rdkit terachem torchani turbomole

@loriab loriab merged commit e370e86 into MolSSI:master Jan 7, 2020
@loriab loriab deleted the nwc_ci branch January 7, 2020 16:22
muammar added a commit to muammar/QCEngine that referenced this pull request Jan 9, 2020
* master: (29 commits)
  CI for NWChem (MolSSI#212)
  Make sure input extras tags get to the output
  Added NWChem to the canonical harness tests
  Calls to rtdb must use all threads
  Remove assumption that NWChem uses original order of atoms
  Fixed test for cores_per_rank
  Correctly determine memory sizes, when MPI should be used
  Account for cores_per_rank when computing total ranks
  Added a more difficult test for the nwchem hessian
  Read hessian array in proper order
  Use pep8 variable names
  Rotate gradients and hessian to match input molecule
  Linted with black
  Added Hessian support and improved gradient accuracy
  Allow for methods that are combinations of several functionals
  psi4 windows version and outfile psiapi mode (MolSSI#201)
  NWCHEM:  added keyword dft to xc_functionals list.  If method == "dft" (MolSSI#204)
  entos: Updated QCER hash and program_overview.rst
  black reformatting
  entos: AO reordering added to unrestricted wavefunction properties
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Related to a testing enhancement or bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NWChem CI
2 participants