Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing import standardization #193

Closed
dgasmith opened this issue Dec 8, 2019 · 0 comments
Closed

Testing import standardization #193

dgasmith opened this issue Dec 8, 2019 · 0 comments
Labels
Enhancement Expansion of a pre-existing feature. Good First Issue Good for newcomers

Comments

@dgasmith
Copy link
Collaborator

dgasmith commented Dec 8, 2019

Currently in the tests there is both from qcengine.testing import ... and from QCEngine import testing. We should settle on a single strategy for code cleanliness. I would propose from qcengine.testing import ... so that this strategy works for both functions and fixtures.
@dgasmith dgasmith added Good First Issue Good for newcomers Enhancement Expansion of a pre-existing feature. labels Dec 8, 2019
muammar added a commit to muammar/QCEngine that referenced this issue Dec 11, 2019
@muammar
Merge branch 'master' into orca
4a125bc 
* master: (21 commits)
  Docs: Changelog 0.13.0 extension
  Psi4: Ensures output data for psi4, fixes MolSSI#176
  Docs: Adds v0.13.0 changelog
  Lint: Fixes GHA routine
  Testing: Canonicalizes from testing, closes MolSSI#193
  Lint: Adds a GHA action to check for Black
  GitHub: Updates tempaltes to QCArchive standard
  Lint: Blackens code base
  Addresses MolSSI#186
  Improved MPI support
  Clarified documentation
  Improved documentation and type checking for node configuration
  Added ability to forward output from popen
  Documentation for configs needed for node-parallel tasks
  Removed unused import
  Bug fix: Use integer division not floating point
  Read from both stderr and stdout to prevent buffer deadlock
  Bug fix: Memory is per MPI rank
  Bug fix: Missing task configuration when making mpi command
  Improved warnings for when multi-node jobs are misconfigured
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Expansion of a pre-existing feature. Good First Issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dgasmith