Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows & poetry? #328

Merged
merged 5 commits into from
Oct 24, 2023
Merged

windows & poetry? #328

merged 5 commits into from
Oct 24, 2023

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Oct 20, 2023 •
edited
Loading

Description

Changelog description

  • add windows testing
  • do workaround for upstream (Py) Windows shutil.which handling bug

Status

  • Code base linted
  • Ready to go

@codecov
Copy link

codecov bot commented Oct 23, 2023 •
edited
Loading

Codecov Report

Merging #328 (b96978f) into master (6988a32) will decrease coverage by 0.04%.
The diff coverage is 33.33%.

Additional details and impacted files

@loriab loriab marked this pull request as ready for review October 23, 2023 23:02
Lnaden
Lnaden approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@Lnaden Lnaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loriab loriab merged commit c8c4aa6 into master Oct 24, 2023
18 checks passed
@loriab loriab mentioned this pull request Oct 26, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lnaden Lnaden Lnaden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loriab @Lnaden