-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs location #311
Update docs location #311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huzzah! This looked like it was a pain for the dependency shenanigans.
Yeah, scipy is an extra dimension to version resolving. Probably we had it in the conda envs but not in setup.py, so Colton didn't notice it for the poetry transition. @Lnaden Also, since we're mostly all new to poetry, the "extras" changes come about because from what I gather from https://python-poetry.org/docs/pyproject/#extras, "extras" are for user subsets for optional add'l capabilites (like viz and align) whereas groups are for sets of development dependencies. The "extras" arg where it was before this PR was actually to pull the "viz" extra from package networkx, not assigning networkx to the qcel "viz" extra. So these changes cut down on the default deps installed (back to numpy, pint, pydantic) unless a Pinging @coltonbh in case I've got this all wrong. :-) But pretty much I'll merge this, make a v0.26.0 tag (even though poetry probably doesn't use it), do the c-f feedstock, then on to qcng (which may in turn necessitate a v0.26.1 here). |
I think that all sounds good. I think doing this, cutting a release ASAP so we can unpin the pydantic would be extremely helpful as I am already working upstream in the QCArchive stack with this release in mind. |
Yes, @loriab is correct. Extras are for end user extras--usually augmented features of your package that you don't want to install by default, often because they are heavy-weight or only used for special cases, but want to make available to end users. You can install them with the usual You'd never want end users to install your developer dependencies--pytest, isort, etc.--and these are placed in the To summarize:
|
Description
qcel hasn't used ReadTheDocs in some time, and I guess the MolSSI qca website isn't redirecting properly to the working GH Pages docs. I get tired of digging for them, so I changed the site link on GH, and this takes care of the readme. I've also put in a PR to the qcel feedstock (we'll wait for more changes there). Back to the psi4 docs ...
Changelog description
Status