Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update after pint v0.20 rearrangement #297

Merged
merged 2 commits into from
Oct 31, 2022
Merged

update after pint v0.20 rearrangement #297

merged 2 commits into from
Oct 31, 2022

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Oct 31, 2022 •
edited
Loading

Description

The pint v0.20 release rearranged its internals such that qcel was throwing cannot import name 'quantity' from 'pint'. This rearranges our imports such that pre- and post-0.20 pint work.

Changelog description

Status

  • Code base linted
  • Ready to go

@codecov
Copy link

codecov bot commented Oct 31, 2022 •
edited
Loading

Codecov Report

Merging #297 (f849ef6) into master (2956421) will decrease coverage by 0.02%.
The diff coverage is 83.33%.

❗ Current head f849ef6 differs from pull request most recent head b8a8a71. Consider uploading reports for the commit b8a8a71 to get more accurate results

Additional details and impacted files

mattwthompson
mattwthompson approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@mattwthompson mattwthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@loriab loriab merged commit f7b2969 into MolSSI:master Oct 31, 2022
@loriab loriab deleted the newpint branch October 31, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwthompson mattwthompson mattwthompson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@loriab @mattwthompson