Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo overzealous autodocs removal #290

Merged
merged 1 commit into from
Jun 9, 2022
Merged

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Jun 8, 2022

Description

Removal of home-grown autodoc in #289, while good, threatened to break qcportal/qcfractal import. Presence restored, though not functionality (which interfered with autodoc-pydantic).

Changelog description

Status

  • Code base linted
  • Ready to go

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #290 (9640904) into master (3766e37) will decrease coverage by 0.01%.
The diff coverage is 87.50%.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 8, 2022

This pull request fixes 1 alert when merging 9640904 into 3766e37 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

Copy link
Contributor

@bennybp bennybp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. Thanks for testing against QCFractal/QCPortal

@loriab loriab merged commit 60934f3 into MolSSI:master Jun 9, 2022
@loriab loriab deleted the pydanticdocs2 branch June 9, 2022 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants