Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Molecule representation should include charge and multiplicity #330

Open
awvwgk opened this issue Oct 30, 2023 · 1 comment · May be fixed by #340
Open

Molecule representation should include charge and multiplicity #330

awvwgk opened this issue Oct 30, 2023 · 1 comment · May be fixed by #340

Comments

@awvwgk
Copy link
Contributor

awvwgk commented Oct 30, 2023

Is your feature request related to a problem? Please describe.

Currently printing a molecule to a string does not include the charge or multiplicity information

Describe the solution you'd like

Instead of printing Molecule(name="C", formula="C", hash="...") printing Molecule(name="C+", formula="2^C+", hash="...") would be preferred. Singlet multiplicity could be omitted from printout

Describe alternatives you've considered

Include multiplicity and charge in the string representation.

Additional context

loriab added a commit to loriab/QCElemental that referenced this issue Jun 19, 2024
@loriab loriab linked a pull request Jun 19, 2024 that will close this issue
2 tasks
@loriab loriab closed this as completed in 5b87192 Jun 21, 2024
@loriab loriab reopened this Jun 25, 2024
@loriab
Copy link
Collaborator

loriab commented Jun 25, 2024

actually will be fixed by #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants