Fixes for 1.0.0 #26
Merged
Fixes for 1.0.0 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Operators are deprecated, instead need to be listed [julia/#22251](JuliaLang/julia#22251) * JSON was missing as a dependency, resulting in an Error/Warning * some imports required the `using Base: <function>` syntax instead `using * Base.<function>`
HildingElmqvist
approved these changes
Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed a few things that needed to be fixed in order for
using Modiato work on a julia 1.0.0:Base.Operatorsis deprecated, instead operators need to be listed julia/#22251JSONwas missing as a dependency, resulting in an Error/Warningusing Base: <function>syntax insteadusing Base.<function>Since I'm not normally involved with this package, I'd be happy if someone could have a look at this to make sure I didn't f* things up.