Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for tengine uint8 #55

Merged
merged 8 commits into from
Mar 15, 2022
Merged

add support for tengine uint8 #55

merged 8 commits into from
Mar 15, 2022

Conversation

requirements.txt Outdated
@@ -1,3 +1,3 @@
torch==1.8.1
torchvision==0.9.1
# torch==1.8.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not compatible with torch v1.81?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, since my developed environment is torch 1.9.0, I remove the requirement of PyTorch 1.8.1 temporarily. But this tengine expansion can be totally compatible with torch v1.8.1, and I will restore the requirements.

@Tracin
Copy link
Contributor

Tracin commented Mar 10, 2022

We hightly recommend to add few test cases for this backend !

@un-knight
Copy link
Contributor Author

un-knight commented Mar 11, 2022

We hightly recommend to add few test cases for this backend !

sure, it's necessary to add test cases, but what kind of test cases do we need? Will a table of metrics about imagenet's accuracy with a model before and after quantization be a helper?

@Tracin
Copy link
Contributor

Tracin commented Mar 11, 2022

We hightly recommend to add few test cases for this backend !

sure, it's necessary to add test cases, but what kind of test cases do we need? Will a table of metrics about imagenet's accuracy with a model before and after quantization be a helper?

Something like https://github.com/ModelTC/MQBench/blob/main/test/backend/test_backend.py will be enough for now.
Any table of metrics on datasets can be very convincing if that is possible !

@un-knight
Copy link
Contributor Author

There is MobileNetV2's accuracy on the ImageNet-1k classification task. Since full training of ImageNet is time-consuming, I just finetune the model for several steps, and this is why the top1 accuracy is lower than expected.

model top1@QAT_tengine_u8 top1@tengine_u8_x86
mobilenet_v2 55.06 54.862

@Tracin Tracin merged commit a5582f4 into ModelTC:main Mar 15, 2022
@XHPlus
Copy link
Contributor

XHPlus commented Mar 15, 2022

Thanks for the awesome PR and looking forward to your continuous contribution! @un-knight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants