Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate file system persister to work with store4 #34

Closed
digitalbuddha opened this issue Dec 17, 2019 · 6 comments
Closed

Migrate file system persister to work with store4 #34

digitalbuddha opened this issue Dec 17, 2019 · 6 comments
Assignees
@digitalbuddha

Comments

@digitalbuddha
Copy link
Contributor

Migrating to Store4 did not migrate the file system module and file system persister to work with the coroutine store4. This issue is to take the file system persister and make it work with source of truth abstraction
@pavlospt
Copy link
Contributor

I can take a look at it! Should I look the Room persister for general direction?

@digitalbuddha
Copy link
Contributor Author

Take a look at store builder and source of truth. That is the interface that was the old "persister"

@digitalbuddha
Copy link
Contributor Author

A good first step is to get https://github.com/dropbox/Store/blob/master/filesystem/src/main/java/com/dropbox/android/external/fs3/FileSystemPersister.kt to integrate with StoreBuilder

@pavlospt
Copy link
Contributor

@digitalbuddha thank you for the tip! I was checking the codebase yesterday, kind of getting my mind around the new design :) Will try to integrate that today!

@pavlospt
Copy link
Contributor

pavlospt commented Jan 2, 2020

I am afraid, I won't be able to take up on this task, due to time constraints + new job 😞 Sorry for that, the issue is up for grabs again!

@digitalbuddha digitalbuddha self-assigned this Jan 3, 2020
@digitalbuddha
Copy link
Contributor Author

Fixed during #56

matt-ramotar pushed a commit to matt-ramotar/store-mirror that referenced this issue Nov 12, 2022
@yigit @digitalbuddha
Merge PersisterPipeline code path (MobileNativeFoundation#34)
e9d6a91 
This CL avoids having two different codepaths based on whether
we skip disk cache or not. It should eventually make it easier
to implement sharing, if we decide to do it here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@digitalbuddha digitalbuddha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pavlospt @digitalbuddha