ipv6 abbreviated address support #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will support ipv6 addresses that are abbreviated with `::` such as
::1 (for 0:0:0:0:0:0:0:1) with some caveats around specifying the port
in the host positional argument.
Help output:
```
$> ./et --help
Remote shell for the busy and impatient
Usage:
et [OPTION...] [user@]host[:port]
Note that 'host' can be a hostname or ipv4 address with or without a port
or an ipv6 address. If the ipv6 address is abbreviated with :: then it must
be specfied without a port (use -p,--port).
-h, --help Print help
--version Print version
-u, --username Username
--host arg Remote host name
...
```
Tests:
```
$> ./et ::1 -p 8080 --macserver
$> ./et 0:0:0:0:0:0:0:1 -p 8080 --macserver
$> ./et 0:0:0:0:0:0:0:1:8080 --macserver
$> ./et ::1 -p 8080 --macserver # fails because defaults to port 2022
```
Fixes MisterTea#537
jshort
commented
Oct 13, 2022
| ("host", "Remote host name", | ||
| cxxopts::value<std::string>()) // |
There was a problem hiding this comment.
I removed all these trailing // as I'm not sure why there are there. It looks like they are supposed to be \ like when you extend a shell command in a script but they are not necessary in this context.
There was a problem hiding this comment.
They are to avoid clang-format from putting multiple options per line
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will support ipv6 addresses that are abbreviated with
::such as::1(for0:0:0:0:0:0:0:1) with some caveats around specifying the portin the host positional argument.
Help output:
Tests:
Fixes #537