Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert user about telemetry and give instructions to remove. Remove IP address from logging. #382 #395

Merged
merged 10 commits into from
Feb 17, 2021

Conversation

MisterTea
Copy link
Owner

…P address from logging. #382

@MisterTea MisterTea changed the title Alert user about telemetry and give instructions to remove. Remove I… Alert user about telemetry and give instructions to remove. Remove IP address from logging. #382 Feb 16, 2021
@codecov-io
Copy link

Codecov Report

Merging #395 (2f50f6b) into master (3942bea) will increase coverage by 13.47%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #395       +/-   ##
===========================================
+ Coverage   57.43%   70.91%   +13.47%     
===========================================
  Files          49       46        -3     
  Lines        3341     2678      -663     
===========================================
- Hits         1919     1899       -20     
+ Misses       1422      779      -643     
Impacted Files Coverage Δ
src/base/Headers.hpp 92.50% <ø> (ø)
src/base/SocketHandler.hpp 80.00% <ø> (ø)
src/terminal/TerminalServer.hpp 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3942bea...2f50f6b. Read the comment docs.

@SuperSandro2000
Copy link
Contributor

Nice. I would still like it to be opt in but better than no opt out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants