Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AndJobs #54

Closed
singularitti opened this issue Aug 21, 2021 · 1 comment · Fixed by #57
Closed

Deprecate AndJobs #54

singularitti opened this issue Aug 21, 2021 · 1 comment · Fixed by #57
Assignees

Comments

@singularitti
Copy link
Member

In PR #47 I created type AndJobs following the instructions from here to let

(job1, job2, job3, job4)

can be written as

job1  job2  job3  job4

However, why should I return AndJobs for job1 → job2? I can just return job2 as a final result. So it can be later chained with other jobs. It's just like

julia> (a, b) = a - b
 (generic function with 1 method)

julia> 1  2  3
2

julia> @which 1  2  3
(a, b) in Main at REPL[1]:1

It calls that method recursively as long as both arguments are Ints.

@singularitti singularitti self-assigned this Aug 21, 2021
singularitti added a commit that referenced this issue Aug 21, 2021
@singularitti
Copy link
Member Author

singularitti commented Aug 21, 2021

In commit 9c81a8d I changed returning AndJobs to just a Job. But this creates some problems: the association rule of is different than I expected (method from here).

julia> "a → b → c → d" |> Meta.parse
:(a  (b  (c  d)))

As you can see, d will always be returned after that commit, so in the end, d will have a, b, and c as its dependencies, while a, b, and c has no dependency. That's not what I want. I want b has a, c has b, and d has c as a dependency. So I need to change to another operator.

Every operator in this row has an association rule like , so I cannot use this row.
The other row seems to be fine:

julia> "a ⊔ b ⊔  c" |> Meta.parse
:((a  b)  c)

singularitti added a commit that referenced this issue Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant