Improve setUser functionality #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UPDATED: I've reverted the changes to user details only being set when the customer isn't anonymous. It's been brought to my attention that the other providers also allow you to set user details on an anonymous customers, so for consistency's sake I will keep this the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes some improvements to the
SetUsermethod. We've had a couple users confused as to why their users aren't being set properly and this is likely due to it not being clear in our documentation thatsetUserexpects theuserparametre to be a string, otherwise the user will be set to anonymous. I've updated the provider to accept numbers for this parametre now.Changes:
userparameter now expects both strings and number data types – theis_stringandis_numericchecks just make sure we're not getting any unexpected data types