Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rosetta: Short circuit recursive near tip #9802

Merged
merged 7 commits into from
Nov 11, 2021

Conversation

bkase
Copy link
Member

@bkase bkase commented Nov 11, 2021

Explain your changes:

  • Make sure the recursive query stops before going too far, and fallback
    to the historical query in that case with (min_recent_height-1)

Explain how you tested your changes:

  • Will want to test live

Make sure the recursive query stops before going too far, and fallback
to the historical query in that case with (min_recent_height-1)
@bkase bkase added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Nov 11, 2021
@psteckler
Copy link
Member

@bkase The old block queries rely on the chain status. For the new block queries, why not recurse until you see canonical status, instead of a fixed recursion length?

@bkase bkase merged commit 784cc54 into rosetta-1.2.1-safe Nov 11, 2021
@bkase bkase deleted the feature/rosetta-quick-recursive branch November 11, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants