Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ubuntu 20.04 and unify dockerfiles across debian/ubuntu #10194

Merged
merged 46 commits into from
Feb 12, 2022

Conversation

lk86
Copy link
Contributor

@lk86 lk86 commented Feb 9, 2022

Explain your changes:

  • Rosetta ubuntu containers were reporting as "stretch" in the docker tag due to old debian-centric defaults, this PR attempts to refactor the docker release script and/or job to use an ubuntu-specific codename in place of stretch to signify ubuntu 20.04
  • Document rosetta 1.3.0 release by updating the readme to use the official release branch
  • Combine staged dockerfiles for ubuntu and debian
  • Support Debian 11 "Bullseye" with an entire MinaArtifact Pipeline
  • Support Ubuntu 20.04 "Focal Fossa" with an entire MinaArtifact pipeline
  • Support Ubuntu 18.04 "Bionic Beaver" in a more industry-standard way, while still sharing some of the logic and the builder container from Debian stretch. In practice these could even be identical packages with different manifests but this is saved for a future PR.
  • Isolate python requirements for various tests onto the debian buster toolchain to simplify the stretch/bionic/focal flows
  • Shorten the Names/Labels on jobs so that the unique parts of the name show up in the buildkite summary
  • Support making ubuntu-based Dockerfile-mina-daemon and Dockerfile-mina-archive builds using the ${image} argument independent from deb_codename
  • Remove unique "Rosetta Ubuntu" container builds, dhall job, and dockerfiles in favor of the generalized version

Explain how you tested your changes:

  • CI

Checklist:

  • [*] Modified the current draft of release notes with details on what is completed or incomplete within this project
  • [*] Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • [*] Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • [*] Does this close issues? List them

@lk86 lk86 requested a review from a team as a code owner February 9, 2022 03:24
…n the rosetta container officially and try to combine the build deps stages back together
@lk86 lk86 added the ci-build-me Add this label to trigger a circle+buildkite build for this branch label Feb 9, 2022
@lk86 lk86 requested a review from a team as a code owner February 9, 2022 04:58
…oroughly and document the staged dockerfile more
…python2 to avoid dependency issues elsewhere
… ubuntu:focal is the default deb_codename and image
@lk86 lk86 changed the title Lk86/remove stretch from rosetta tag Support Ubuntu 20.04 and unify dockerfiles across debian/ubuntu Feb 10, 2022
Copy link
Contributor

@stevenplatt stevenplatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the reported merge conflicts, I don't spot any items to flag in the code.

@lk86
Copy link
Contributor Author

lk86 commented Feb 11, 2022

Other than the reported merge conflicts, I don't spot any items to flag in the code.

The conflicts are resolved in #10212 which will merge first

@lk86 lk86 merged commit 57deb33 into compatible Feb 12, 2022
@lk86 lk86 deleted the lk86/remove-stretch-from-rosetta-tag branch February 12, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-build-me Add this label to trigger a circle+buildkite build for this branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants